Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic when gitea commit object contains nil pointers #237

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix panic when gitea commit object contains nil pointers #237

merged 2 commits into from
Jul 7, 2023

Conversation

souleb
Copy link
Member

@souleb souleb commented Jul 6, 2023 •
edited
Loading

Description

fix panic when gitea commit object contains nil pointers

Test results

https://github.com/fluxcd/go-git-providers/actions/runs/5475990179/jobs/9972869429

@souleb souleb force-pushed the fix-commic-panic branch from 096659c to 211750e Compare July 6, 2023 13:22
@souleb souleb requested a review from makkes July 6, 2023 13:25
makkes
makkes approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Would it be possible to have a dedicated regression test for this specific occasion?

@souleb souleb force-pushed the fix-commic-panic branch from 211750e to 02195df Compare July 7, 2023 12:38
@souleb souleb merged commit d346f57 into main Jul 7, 2023
@souleb souleb deleted the fix-commic-panic branch July 7, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@souleb @makkes